Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lunar Keyboard #4976

Merged
merged 13 commits into from
Jan 28, 2019
Merged

Add Lunar Keyboard #4976

merged 13 commits into from
Jan 28, 2019

Conversation

ai03-2725
Copy link
Contributor

@ai03-2725 ai03-2725 commented Jan 28, 2019

Adds the Lunar by Switchplate Peripherals.

The two supplied keymaps by default:

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

None

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@wilba
Copy link
Contributor

wilba commented Jan 28, 2019

@drashna approved by me

Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this in! Just a few minor formatting changes.

SWPLURL
};

#define _______ KC_TRNS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually included when you #include QMK_KEYBOARD_H

Suggested change
#define _______ KC_TRNS

*/
#include QMK_KEYBOARD_H

#define _______ KC_TRNS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Suggested change
#define _______ KC_TRNS

A 65% keyboard made specifically for Alps SKCM/L switches and AEK/M0116 keycaps.

Keyboard Maintainer: [ai03](https://github.com/ai03-2725)
Hardware Supported: Official Lunar PCB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a few spaces here to get markdown to render properly

Suggested change
Hardware Supported: Official Lunar PCB
Hardware Supported: Official Lunar PCB

@ai03-2725
Copy link
Contributor Author

Sent in a commit for the requested changes.

Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My name is Merlin, and I approve this PR.

@mechmerlin mechmerlin merged commit 5672dc8 into qmk:master Jan 28, 2019
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 9, 2019
* Generate project

* Adjust files

* Get things working

* Update readme

* Add VIA configurator compatibility

* Grammar

* Update keymap

* Split lunar info default and VIA keymaps

* Copyrights

* VIA tuneup

* A few missed copyrights

* Remove unnecessary junk

* Remove unnecessary bits, fix readme
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* Generate project

* Adjust files

* Get things working

* Update readme

* Add VIA configurator compatibility

* Grammar

* Update keymap

* Split lunar info default and VIA keymaps

* Copyrights

* VIA tuneup

* A few missed copyrights

* Remove unnecessary junk

* Remove unnecessary bits, fix readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants