Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Orthodox to Split Common code #4975

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Convert Orthodox to Split Common code #4975

merged 3 commits into from
Apr 5, 2019

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 28, 2019

Description

This converts the Orthodox to using the SPLIT_KEYBOARD function, so that it's using the split common code, and getting benefit out of the improvements there.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member Author

drashna commented Jan 28, 2019

This needs to have #4974 merged first, to support >8 columns over i2c.
And needs somebody to test it.

@drashna drashna force-pushed the feature/orthodox_split_common branch 2 times, most recently from 5de63ab to 6d556f8 Compare February 9, 2019 19:56
@drashna drashna force-pushed the feature/orthodox_split_common branch 2 times, most recently from 68d7644 to 91446f7 Compare March 18, 2019 20:08
@drashna
Copy link
Member Author

drashna commented Mar 20, 2019

@mechmerlin want to merge?

Tested and works with pelruns i2c fix.
Travis CI errors are due to my keymaps being too large.

r2d2rogers
r2d2rogers approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@r2d2rogers r2d2rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working on my Orthodox.

@skullydazed
Copy link
Member

Can you remove the user keymap changes from this? Otherwise it looks good to me.

@drashna
Copy link
Member Author

drashna commented Mar 22, 2019

Done.

@drashna drashna requested a review from yanfali March 23, 2019 01:01
@drashna drashna force-pushed the feature/orthodox_split_common branch from 5530a35 to 9277b55 Compare March 23, 2019 03:03
@drashna drashna requested a review from noroadsleft April 4, 2019 01:24
@drashna
Copy link
Member Author

drashna commented Apr 5, 2019

Travis CI errors are because my keymaps are too large (lies!! well... maybe.... I'm using avr-gcc 8.3, which compiles smaller than travis' 5.4.0)

@skullydazed skullydazed merged commit cb33643 into qmk:master Apr 5, 2019
@drashna drashna deleted the feature/orthodox_split_common branch April 5, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vomindoraan vomindoraan vomindoraan left review comments

@r2d2rogers r2d2rogers r2d2rogers approved these changes

@skullydazed skullydazed skullydazed approved these changes

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

@yanfali yanfali Awaiting requested review from yanfali

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drashna @skullydazed @r2d2rogers @vomindoraan