Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default layout for e6_rgb #4973

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Add default layout for e6_rgb #4973

merged 1 commit into from
Jan 28, 2019

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 28, 2019

Description

The E6_Rgb keyboard lacks a default keymap.

Travis didn't error out on the board, so it didn't get noticed when merged. But causes errors globally, now.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

  • Travis CI errors

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from mechmerlin January 28, 2019 02:12
mechmerlin
mechmerlin approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaay

@mechmerlin mechmerlin merged commit af04936 into qmk:master Jan 28, 2019
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 9, 2019
@drashna @zer09
Add default layout for e6_rgb (qmk#4973)
6238756
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@drashna
Add default layout for e6_rgb (qmk#4973)
77a9e4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
bug keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @mechmerlin