Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rgb pcb for e6 keyboard #4928

Merged
merged 4 commits into from
Jan 28, 2019
Merged

add rgb pcb for e6 keyboard #4928

merged 4 commits into from
Jan 28, 2019

Conversation

yulei
Copy link
Contributor

@yulei yulei commented Jan 24, 2019 •
edited by drashna
Loading

A full RGB led pcb for e6v1&v2

Description

add a new rgb pcb for e6 keyboard

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Jan 25, 2019
View reviewed changes
keyboards/e6_rgb/config.h Outdated Show resolved Hide resolved
keyboards/e6_rgb/config.h Outdated Show resolved Hide resolved
keyboards/e6_rgb/keymaps/60_ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/e6_rgb/keymaps/60_hhkb/keymap.c Outdated Show resolved Hide resolved
keyboards/e6_rgb/keymaps/60_split_bs_shift/keymap.c Outdated Show resolved Hide resolved
keyboards/e6_rgb/keymaps/60_wkl/keymap.c Outdated Show resolved Hide resolved
keyboards/e6_rgb/keymaps/60_wkl_split_bs/keymap.c Outdated Show resolved Hide resolved
keyboards/e6_rgb/readme.md Show resolved Hide resolved
keyboards/e6_rgb/rules.mk Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Jan 25, 2019
View reviewed changes
keyboards/e6_rgb/config.h Outdated
#define RETRO_TAPPING
#define PERMISSIVE_HOLD

#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#endif

keyboards/e6_rgb/e6_rgb.h Outdated Show resolved Hide resolved
keyboards/e6_rgb/e6_rgb.h Outdated Show resolved Hide resolved
keyboards/e6_rgb/e6_rgb.h Outdated Show resolved Hide resolved
keyboards/e6_rgb/e6_rgb.h Outdated Show resolved Hide resolved
keyboards/e6_rgb/info.json Outdated Show resolved Hide resolved
keyboards/e6_rgb/info.json Outdated Show resolved Hide resolved
keyboards/e6_rgb/info.json Outdated Show resolved Hide resolved
keyboards/e6_rgb/rules.mk Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Jan 28, 2019

Awesome! Thanks!

@drashna drashna merged commit 996ada1 into qmk:master Jan 28, 2019
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 9, 2019
@yulei @zer09
[Keyboard] add rgb pcb for e6 keyboard (qmk#4928)
07e378b 
* add e6_rgb

* update according to the reviewer

* fixed readme.md

* rename 60_split_bs_shift to 60_ansi_split_bs_shift
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@yulei
[Keyboard] add rgb pcb for e6 keyboard (qmk#4928)
9839019 
* add e6_rgb

* update according to the reviewer

* fixed readme.md

* rename 60_split_bs_shift to 60_ansi_split_bs_shift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vomindoraan vomindoraan vomindoraan left review comments

@noroadsleft noroadsleft noroadsleft requested changes

@drashna drashna drashna approved these changes

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yulei @drashna @vomindoraan @noroadsleft @mechmerlin