Make Ergodox EZ Glow's rgb matrix user configurable #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
force-pushed
the
ergodox_ez_glow_configurable
branch
from
c5fe2c7 to
bdd4171
Compare
|
I've asked @fdidron to take a look here, he is our main developer for the configurator which obviously integrates very tightly with QMK, and is now doing a bunch of LED work as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this is so that people (like myself) can configure the "modifiers" for the RGB Matrix, if they so desire.
This also fixes the "i2c_master.d added more than once" error, as it now will only include the file if the rgb matrix feature isn't enabled (as that includes the file, too).
And added a
default_glowkeymap (that just points to the default keymap, but enables the rgb matrix and disables rgb lights (underglow).