Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mechboards Lily58 variant and common code. #24937

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Add Mechboards Lily58 variant and common code. #24937

merged 3 commits into from
Feb 28, 2025

Conversation

daskygit
Copy link
Member

OLED code will be reused in at least 2 more keyboards so thought a common folder would be appropriate. It's quite likely the r2g boards will get moved here and reuse the code.

I'm sure I've missed something so thanks in advance.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 reviewed Feb 21, 2025
View reviewed changes
@daskygit
Copy link
Member Author

Thanks for the fast review.

@drashna drashna merged commit a4d86a6 into qmk:master Feb 28, 2025
3 checks passed
@daskygit daskygit deleted the pr/lily58_common branch February 28, 2025 19:45
@daskygit
Copy link
Member Author

Thank you.

johanbast pushed a commit to johanbast/qmk_firmware that referenced this pull request Feb 28, 2025
@daskygit @waffle87 @johanbast
Add Mechboards Lily58 variant and common code. (qmk#24937)
1dd2f6f 
* Add lily58 and common code

* Apply suggestions from code review

Co-authored-by: jack <[email protected]>

* Apply suggestions from code review

Co-authored-by: jack <[email protected]>

---------

Co-authored-by: jack <[email protected]>
@daskygit daskygit mentioned this pull request Mar 4, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskygit @drashna @waffle87