Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate some DEFAULT_FOLDER to keyboard_aliases.hjson #24915

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Migrate some DEFAULT_FOLDER to keyboard_aliases.hjson #24915

merged 1 commit into from
Feb 16, 2025

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 13, 2025 •
edited
Loading

Description

Manually migrated keyboard rules.mk which contain DEFAULT_FOLDER.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard dd Data Driven Changes labels Feb 13, 2025
@zvecr zvecr force-pushed the deprecate_default_folder6 branch from 25e5dee to ed64d52 Compare February 13, 2025 14:17
@zvecr zvecr force-pushed the deprecate_default_folder6 branch from ed64d52 to cce49e4 Compare February 13, 2025 14:19
@zvecr zvecr added the breaking_change_2025q1 Targeting breaking changes Q1 2025 label Feb 16, 2025
tzarc
tzarc approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA1s are all identical.

@tzarc tzarc merged commit 164b733 into qmk:develop Feb 16, 2025
2 of 3 checks passed
johanbast pushed a commit to johanbast/qmk_firmware that referenced this pull request Feb 28, 2025
@zvecr @johanbast
Migrate some DEFAULT_FOLDER to keyboard_aliases.hjson (qmk#24915)
471ca22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
breaking_change_2025q1 Targeting breaking changes Q1 2025 dd Data Driven Changes keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc