Fix startup sound for Planck (#8852) #24893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waffle87
approved these changes
Feb 2, 2025
drashna
reviewed
Feb 3, 2025
There was a problem hiding this comment.
As audio is enabled at the keyboard level, it would probably be best to enable this at the keyboard level too. keyboards/planck/config.h already has some audio config there, so setting it there should be okay-ish. (and this setting doesn't really hurt the boards that don't need it...)
|
Config moved to |
drashna
approved these changes
Feb 5, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
haxwagon
pushed a commit
to haxwagon/qmk_firmware
that referenced
this pull request
Feb 19, 2025
slotThe
pushed a commit
to slotThe/qmk_firmware
that referenced
this pull request
Feb 24, 2025
TinfoilSubmarine
pushed a commit
to TinfoilSubmarine/qmk_firmware
that referenced
this pull request
Feb 24, 2025
TinfoilSubmarine
pushed a commit
to TinfoilSubmarine/qmk_firmware
that referenced
this pull request
Feb 24, 2025
TinfoilSubmarine
pushed a commit
to TinfoilSubmarine/qmk_firmware
that referenced
this pull request
Feb 24, 2025
TinfoilSubmarine
pushed a commit
to TinfoilSubmarine/qmk_firmware
that referenced
this pull request
Feb 24, 2025
dslittle22
pushed a commit
to dslittle22/qmk_firmware
that referenced
this pull request
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add to Planck config to resolve #8852, as suggested by Drashna.
Types of Changes
Issues Fixed or Closed by This PR
Checklist