Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CORTEX_ENABLE_WFI_IDLE for kinesis/kint41. #24866

Closed
wants to merge 1 commit into from

Conversation

JiddoDev
Copy link

@JiddoDev JiddoDev commented Jan 25, 2025

Fix for #24865.
CORTEX_ENABLE_WFI_IDLE was globally enabled for all keyboards in 416af01. This breaks the Teensy 4.0. This change explicitly disables WFI idle for kinesis/kint41.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Fix for qmk#24865.
CORTEX_ENABLE_WFI_IDLE was globally enabled for all keyboards in 416af01. This breaks the Teensy 4.0. This change explicitly disables WFI idle for kinesis/kint41.
@fauxpark
Copy link
Member

This breaks the Teensy 4.0

Probably because, like the rest of the Teensy 4.x implementation in ChibiOS, it's very unfinished. Please fix it there.

@fauxpark fauxpark closed this Jan 25, 2025
@JiddoDev
Copy link
Author

This breaks the Teensy 4.0

Probably because, like the rest of the Teensy 4.x implementation in ChibiOS, it's very unfinished. Please fix it there.

I have no idea how to get WFI idle to work in ChibiOS. Does it not make sense to selectively disable it for this particular keyboard until that feature works properly?

@fauxpark
Copy link
Member

Only if we can guarantee someone is going to get it to work properly, then come back and revert this. As it stands this is an issue in ChibiOS, not the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants