Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard Cloak #24858

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add keyboard Cloak #24858

wants to merge 12 commits into from
+209 −0

Conversation

dnlnm
Copy link

@dnlnm dnlnm commented Jan 23, 2025

Add keyboard Cloak

Description

This is for hot-swap Cloak PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Jan 23, 2025
View reviewed changes
keyboards/dnlnm/cloak/cloak.c Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/keyboard.json Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/dnlnm/cloak/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/readme.md Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/keyboard.json Show resolved Hide resolved
keyboards/dnlnm/cloak/keyboard.json Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/keyboard.json Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/keyboard.json Outdated Show resolved Hide resolved
@dnlnm dnlnm requested a review from waffle87 January 24, 2025 07:11
waffle87
waffle87 reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above outstanding comment(s) as well.

keyboards/dnlnm/cloak/keymaps/default/keymap.c Outdated Show resolved Hide resolved
drashna
drashna requested changes Jan 25, 2025
View reviewed changes
keyboards/dnlnm/cloak/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/keyboard.json Outdated Show resolved Hide resolved
keyboards/dnlnm/cloak/.vscode/settings.json Outdated Show resolved Hide resolved
@dnlnm dnlnm requested a review from drashna January 26, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnlnm @drashna @waffle87