Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ferris/0_1: update I2C API usage #24839

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

fauxpark
Copy link
Member

Description

These I2C_READ and I2C_WRITE defines don't need to exist.

The custom matrix code for ferris/0_1 has been updated to align more closely with 0_2 by using i2c_read/write_register() instead. This was actually already done for 0_2 in #21273, but not 0_1 for some reason. They could possibly be completely identical but I mainly just wanted to clean up the i2c_master header.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 68130cc into qmk:develop Jan 20, 2025
5 checks passed
@fauxpark fauxpark deleted the ferris-0-1-update-i2c branch January 21, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants