Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid "effect_max" animation from keyboards #24767

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Remove invalid "effect_max" animation from keyboards #24767

merged 2 commits into from
Dec 31, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 31, 2024 •
edited
Loading

Description

effect_max is not a valid animation so should never be specified.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit fe2200f into master Dec 31, 2024
3 checks passed
@zvecr zvecr deleted the zvecr-patch-1 branch December 31, 2024 12:36
haxwagon pushed a commit to haxwagon/qmk_firmware that referenced this pull request Jan 3, 2025
@zvecr @haxwagon
Remove invalid "effect_max" animation from keyboards (qmk#24767)
05e2101
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@zvecr @LeonMusCoden
Remove invalid "effect_max" animation from keyboards (qmk#24767)
9db06b1
ichichou pushed a commit to ichichou/qmk_firmware that referenced this pull request Jan 8, 2025
@zvecr @ichichou
Remove invalid "effect_max" animation from keyboards (qmk#24767)
3cba1e7
le4ker pushed a commit to le4ker/lily58-firmware that referenced this pull request Jan 8, 2025
@zvecr @le4ker
Remove invalid "effect_max" animation from keyboards (qmk#24767)
177b977
MichaelScofield45 pushed a commit to MichaelScofield45/qmk_firmware that referenced this pull request Jan 8, 2025
@zvecr @MichaelScofield45
Remove invalid "effect_max" animation from keyboards (qmk#24767)
88d48fd
milosbugarinovic pushed a commit to milosbugarinovic/qmk_firmware that referenced this pull request Jan 13, 2025
@zvecr @milosbugarinovic
Remove invalid "effect_max" animation from keyboards (qmk#24767)
d7c835b
pashashocky pushed a commit to pashashocky/qmk that referenced this pull request Jan 17, 2025
@zvecr @pashashocky
Remove invalid "effect_max" animation from keyboards (qmk#24767)
53bfb21
vinniefranco pushed a commit to Good-Great-Grand-Wonderful/qmk_firmware that referenced this pull request Jan 20, 2025
@zvecr
Remove invalid "effect_max" animation from keyboards (qmk#24767)
9def328
fsecilia pushed a commit to fsecilia/qmk_firmware that referenced this pull request Jan 27, 2025
@zvecr @fsecilia
Remove invalid "effect_max" animation from keyboards (qmk#24767)
d765997
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
@zvecr @Rumadon
Remove invalid "effect_max" animation from keyboards (qmk#24767)
b0dda15
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
@zvecr
Remove invalid "effect_max" animation from keyboards (qmk#24767)
146f401
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@zvecr @alinelena
Remove invalid "effect_max" animation from keyboards (qmk#24767)
3a1fa20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @waffle87