Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global k_rgb_matrix_split #24348

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Remove global k_rgb_matrix_split #24348

merged 1 commit into from
Sep 1, 2024

Conversation

t-8ch
Copy link
Contributor

@t-8ch t-8ch commented Aug 31, 2024

Description

Remove global k_rgb_matrix_split, all users have their own local definition.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@t-8ch
Remove global k_rgb_matrix_split
f13c88d 
All users have their own local definition.
@github-actions github-actions bot added the core label Aug 31, 2024
@drashna drashna requested a review from a team September 1, 2024 03:32
@waffle87 waffle87 merged commit 9df36b2 into qmk:develop Sep 1, 2024
3 of 4 checks passed
@fauxpark
Copy link
Member

fauxpark commented Sep 1, 2024

This should also have been done for LED Matrix before merging.

waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Sep 6, 2024
@t-8ch @waffle87
Remove global k_rgb_matrix_split (qmk#24348)
6b19217 
All users have their own local definition.
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Sep 6, 2024
@t-8ch @waffle87
Remove global k_rgb_matrix_split (qmk#24348)
60b4c04 
All users have their own local definition.
fauxpark added a commit to fauxpark/qmk_firmware that referenced this pull request Sep 12, 2024
@fauxpark
Revert "Remove global k_rgb_matrix_split (qmk#24348)"
2f75abe 
This reverts commit 9df36b2.
@fauxpark fauxpark mentioned this pull request Sep 12, 2024
Merged
14 tasks
itsme-zeix pushed a commit to itsme-zeix/qmk_firmware that referenced this pull request Oct 2, 2024
@t-8ch @itsme-zeix
Remove global k_rgb_matrix_split (qmk#24348)
1f6cab9 
All users have their own local definition.
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@t-8ch @ilham-agustiawan
Remove global k_rgb_matrix_split (qmk#24348)
0186e00 
All users have their own local definition.
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@t-8ch @smallketchup82
Remove global k_rgb_matrix_split (qmk#24348)
85df985 
All users have their own local definition.
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@t-8ch @jlaptavi
Remove global k_rgb_matrix_split (qmk#24348)
ca8b772 
All users have their own local definition.
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@t-8ch @DmNosachev
Remove global k_rgb_matrix_split (qmk#24348)
8b4efe4 
All users have their own local definition.
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@t-8ch @SyrupSplashin
Remove global k_rgb_matrix_split (qmk#24348)
4d1c3f9 
All users have their own local definition.
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@t-8ch @LeonMusCoden
Remove global k_rgb_matrix_split (qmk#24348)
f4b2034 
All users have their own local definition.
MichaelScofield45 pushed a commit to MichaelScofield45/qmk_firmware that referenced this pull request Jan 8, 2025
@t-8ch @MichaelScofield45
Remove global k_rgb_matrix_split (qmk#24348)
3e2b1a0 
All users have their own local definition.
pashashocky pushed a commit to pashashocky/qmk that referenced this pull request Jan 17, 2025
@t-8ch @pashashocky
Remove global k_rgb_matrix_split (qmk#24348)
c586172 
All users have their own local definition.
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
@t-8ch @Rumadon
Remove global k_rgb_matrix_split (qmk#24348)
ba35d62 
All users have their own local definition.
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
@t-8ch
Remove global k_rgb_matrix_split (qmk#24348)
16b4d89 
All users have their own local definition.
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@t-8ch @alinelena
Remove global k_rgb_matrix_split (qmk#24348)
20e8370 
All users have their own local definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-8ch @fauxpark @drashna @waffle87