Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candy87 PCB Firmware #24298

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Candy87 PCB Firmware #24298

wants to merge 10 commits into from

Conversation

rarepotato8de
Copy link
Contributor

Candy87 Firmware

Description

This is the initial firmware for the Candy87 PCB that is offered by Candykeys.
This PCB was designed for the Geonworks F1-8X V2.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@rarepotato8de
candy87 init
af17af0 
candy87 v2 firmware, working and tested
zvecr
zvecr requested changes Aug 18, 2024
View reviewed changes
keyboards/candykeys/candy87/rules.mk Outdated Show resolved Hide resolved
keyboards/candykeys/candy87/readme.md Show resolved Hide resolved
keyboards/candykeys/candy87/info.json Outdated Show resolved Hide resolved
keyboards/candykeys/candy87/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/candykeys/candy87/info.json Outdated Show resolved Hide resolved
rarepotato8de and others added 4 commits August 18, 2024 14:52
@rarepotato8de @zvecr
Update keyboards/candykeys/candy87/info.json
af640a8 
Co-authored-by: Joel Challis <[email protected]>
@rarepotato8de @zvecr
Update keyboards/candykeys/candy87/keymaps/default/keymap.c
f810dd3 
Co-authored-by: Joel Challis <[email protected]>
@rarepotato8de
Commit changes
2fc2827 
Removed old rules.mk
info.json renamed to keyboard.json
@rarepotato8de
Added many layout options
be1d495 
iso, ansi, f12 and f13 layouts + community layouts
@rarepotato8de
All layouts
7c83cf5 
Added keymaps for all possible layouts
@rarepotato8de rarepotato8de requested a review from zvecr August 25, 2024 19:02
dunk2k
dunk2k suggested changes Aug 27, 2024
View reviewed changes
keyboards/candykeys/candy87/keyboard.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 14, 2024
@rarepotato8de
All community layouts added
b0432a8 
Added WKL and full backspace/ right shift community layouts as requested in my PR
@rarepotato8de rarepotato8de requested a review from dunk2k October 20, 2024 13:40
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 5, 2024
waffle87
waffle87 reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple requests for the keymaps:

  • RGB Matrix keycodes should be added to layer 1
  • QK_BOOT keycode would also be nice to have on layer 1
  • Replace keycodes with their short alias ie. KC_PRINT_SCREEN -> KC_PSCR, KC_BACKSPACE -> KC_BSPC, etc. Refer to the keycode list in the documentation.

keyboards/candykeys/candy87/candy87.c Outdated Show resolved Hide resolved
keyboards/candykeys/candy87/keyboard.json Show resolved Hide resolved
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 6, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 21, 2025
rarepotato8de and others added 2 commits January 26, 2025 22:18
@rarepotato8de @waffle87
Update keyboards/candykeys/candy87/candy87.c
94d3e5a 
Co-authored-by: jack <[email protected]>
@rarepotato8de
Keymap Update
e19f557 
Added RGB Matrix Keycodes, Aliases and formatting as requested for the PR
@rarepotato8de
Copy link
Contributor Author

Done a lot of changes

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jan 27, 2025
@rarepotato8de
Manufacturer Naming
103fb98 
Capital "K" for the brand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 left review comments

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@dunk2k dunk2k Awaiting requested review from dunk2k

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rarepotato8de @drashna @zvecr @waffle87 @dunk2k