Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend lint to reject 'blank' files #23994

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Extend lint to reject 'blank' files #23994

merged 1 commit into from
Feb 12, 2025

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 25, 2024

Description

This will cover the legacy rules.mk files containing

# This file intentionally left blank

As well as the older template config.h files that only contained comments.

Code is mostly set up to also cover keymaps, but this will be enabled separately due to some files maybe having "useful" comments.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Jun 25, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 10, 2024
@zvecr zvecr added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Aug 10, 2024
@drashna drashna requested a review from a team December 24, 2024 07:27
@zvecr zvecr changed the base branch from master to develop February 12, 2025 15:12
@zvecr zvecr merged commit 37e2342 into develop Feb 12, 2025
6 of 7 checks passed
@zvecr zvecr deleted the lint_blank_files branch February 12, 2025 17:16
johanbast pushed a commit to johanbast/qmk_firmware that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants