Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD extra configs for LED/RGB Matrix #21598

Closed
wants to merge 5 commits into from
Closed

Conversation

dexter93
Copy link
Contributor

@dexter93 dexter93 commented Jul 24, 2023

Configs migration for framebuffer, reactive effects and usb suspend disable

invocation example

    "rgb_matrix": {
        "disable_on_suspend" : true,
        "framebuffer": true,
         "reactive": {
              "keypresses" : true,
              "keyreleases" : false
          },
    }

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Jul 24, 2023
@dexter93 dexter93 changed the title DD framebuffer and reactive configs for LED/RGB Matrix DD extra configs for LED/RGB Matrix Jul 24, 2023
dexter93 and others added 2 commits July 24, 2023 16:12
guard against arbitrary properties

Co-authored-by: Sergey Vlasov <[email protected]>
no need to complicate things :)
@github-actions github-actions bot removed python cli qmk cli command labels Jul 24, 2023
@dexter93 dexter93 requested a review from sigprof July 24, 2023 13:26
@zvecr zvecr added the on hold label Jul 24, 2023
@zvecr zvecr self-assigned this Jul 24, 2023
@drashna drashna requested a review from a team July 28, 2023 05:14
@zvecr zvecr mentioned this pull request Sep 6, 2023
14 tasks
@zvecr
Copy link
Member

zvecr commented Sep 26, 2023

Implemented as 21939.

@zvecr zvecr closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants