-
-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Chaz #21207
Add support for Chaz #21207
Conversation
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
I saw some comments come through relating to info.json information duplicated across files. I went to reply and they're missing now so I assume a single, all encompassing comment is coming? There is a lot of overlap between the two version info.json. Is it safe to assume all of that overlap can be moved to the top level info.json? |
you got it chief! There's argument for moving/merging the readme.md's to keyboard level, but I'll let the collaborators call that one 😉 |
@dunk2k right on. I applied your suggestions and will wait to see what the collaborators say about the readme. Thanks for your feedback! |
Co-authored-by: jack <[email protected]>
@@ -0,0 +1,9 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's using the same pinout as the pro micro, correct?
@drashna I realized converters could be specified via rules.mk. I've rearranged things to a single top-level |
@@ -0,0 +1 @@ | |||
CONVERT_TO=rp2040_ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converters at keyboard level won't work with Configurator.
Description
Adding support for Chaz.
Had a previous PR for this board (#21091) but after seeing #21186 I closed it rework for RP2040 configurator support.
Types of Changes
Issues Fixed or Closed by This PR
Checklist