-
-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for trainpad #20973
Added Support for trainpad #20973
Conversation
added support for trainpad
corrected capitalisation
Co-authored-by: Pablo Martínez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the readme
, this is a handwired project -- thus this keyboard should be moved under the handwired
folder.
You will also need to migrate this keyboard to use info.json
as the primary source of configuration information. qmk info -f json -kb handwired/trainpad
can help with this, though that tool's output should not be cut-pasted unedited as it contains fields that are unnecessary. Please examine recently-accepted pull requests to get a better understanding of what this file looks like.
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
updated readme to remove handwire, and corrected number of keys
removed config.h, trainpad.c and trainpad.h
upadted readme to correct capitalisation
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
@noroadsleft any other changes needed? |
Co-authored-by: James Young <[email protected]>
Looks good, thanks! |
For future reference, we recommend against committing to your There are instructions on how to keep your fork updated here: Best Practices: Your Fork's Master: Update Often, Commit Never Fixing Your Branch will walk you through fixing up your Thanks for contributing! |
thank you for this! Sorry for all the trouble and your kind effort. It has been a while since I have done this. Thank you for being patient! |
added support for trainpad
Add support for TrainPad
Description
Added Support for trainpad
Types of Changes
Issues Fixed or Closed by This PR
Checklist
-[x] I have read the PR Checklist document and have made the appropriate changes.