Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for trainpad #20973

Merged
merged 14 commits into from
May 21, 2023
Merged

Added Support for trainpad #20973

merged 14 commits into from
May 21, 2023

Conversation

AnanyaKirti
Copy link
Contributor

added support for trainpad

Add support for TrainPad

Description

Added Support for trainpad

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
    -[x] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

added support for trainpad
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 17, 2023
corrected capitalisation
keyboards/trainpad/config.h Outdated Show resolved Hide resolved
keyboards/trainpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/trainpad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/trainpad/rules.mk Outdated Show resolved Hide resolved
keyboards/trainpad/trainpad.c Outdated Show resolved Hide resolved
keyboards/trainpad/trainpad.h Outdated Show resolved Hide resolved
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the readme, this is a handwired project -- thus this keyboard should be moved under the handwired folder.

You will also need to migrate this keyboard to use info.json as the primary source of configuration information. qmk info -f json -kb handwired/trainpad can help with this, though that tool's output should not be cut-pasted unedited as it contains fields that are unnecessary. Please examine recently-accepted pull requests to get a better understanding of what this file looks like.

keyboards/trainpad/config.h Outdated Show resolved Hide resolved
keyboards/trainpad/readme.md Outdated Show resolved Hide resolved
keyboards/trainpad/readme.md Outdated Show resolved Hide resolved
keyboards/trainpad/readme.md Outdated Show resolved Hide resolved
keyboards/trainpad/trainpad.h Outdated Show resolved Hide resolved
keyboards/trainpad/info.json Outdated Show resolved Hide resolved
keyboards/trainpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/trainpad/trainpad.c Outdated Show resolved Hide resolved
keyboards/trainpad/trainpad.h Outdated Show resolved Hide resolved
keyboards/trainpad/config.h Outdated Show resolved Hide resolved
AnanyaKirti and others added 5 commits May 19, 2023 04:09
updated readme to remove handwire, and corrected number of keys
removed config.h, trainpad.c and trainpad.h
upadted readme to correct capitalisation
keyboards/trainpad/info.json Outdated Show resolved Hide resolved
keyboards/trainpad/info.json Outdated Show resolved Hide resolved
keyboards/trainpad/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/trainpad/rules.mk Outdated Show resolved Hide resolved
@AnanyaKirti
Copy link
Contributor Author

@noroadsleft any other changes needed?

@AnanyaKirti AnanyaKirti requested a review from noroadsleft May 21, 2023 09:40
keyboards/trainpad/readme.md Outdated Show resolved Hide resolved
@AnanyaKirti AnanyaKirti requested a review from noroadsleft May 21, 2023 15:52
@noroadsleft
Copy link
Member

Looks good, thanks!

@noroadsleft noroadsleft merged commit 08a8d35 into qmk:master May 21, 2023
@noroadsleft
Copy link
Member

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

Fixing Your Branch will walk you through fixing up your master branch moving forward. If you need any help with this just ask.

Thanks for contributing!

@AnanyaKirti
Copy link
Contributor Author

thank you for this! Sorry for all the trouble and your kind effort. It has been a while since I have done this. Thank you for being patient!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants