Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert RESET-> QK_BOOT in Read Me files where applicable #19262

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Revert RESET-> QK_BOOT in Read Me files where applicable #19262

merged 1 commit into from
Dec 8, 2022

Conversation

ToastyStoemp
Copy link
Contributor

@ToastyStoemp ToastyStoemp commented Dec 8, 2022 •
edited
Loading

Description

During the rename of RESET to QK_BOOT (#18110) some Read Me files were changed while describing labels or function rather than keycode. This PR reverts the changes where needed.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboard-magpie
keyboard-magpie approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well remedied. What was your search strategy?

@ToastyStoemp
Copy link
Contributor Author

Well remedied. What was your search strategy?

Just opened the #18110 on one monitor, scrolled through the changes. Since most keyboards use the same text lines it was quite quick to scroll through and only read them when they were different

@tzarc tzarc merged commit c6e291c into qmk:develop Dec 8, 2022
@ToastyStoemp ToastyStoemp deleted the fix_readme_reset_overhaul branch December 8, 2022 19:07
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@ToastyStoemp @omikronik
Revert RESET-> QK_BOOT in Read Me files where applicable (qmk#19262)
bdd93a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ToastyStoemp @tzarc @keyboard-magpie