Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix v-usb connection enumeration, ifdef workaround #16511

Merged
merged 3 commits into from
Mar 3, 2022
Merged

fix v-usb connection enumeration, ifdef workaround #16511

merged 3 commits into from
Mar 3, 2022

Conversation

gompa
Copy link

@gompa gompa commented Mar 3, 2022 •
edited by zvecr
Loading

Description

fix v-usb usb reporting by enabling empty reports for vusb

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

fixes vusb enumeration issues

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Mar 3, 2022
@zvecr zvecr added the bug label Mar 3, 2022
KarlK90
KarlK90 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The breakage was introduced by #14065 and I'll follow up on this when I get hardware to investigate.

zvecr
zvecr requested changes Mar 3, 2022
View reviewed changes
quantum/action_util.c Outdated Show resolved Hide resolved
quantum/action_util.c Outdated Show resolved Hide resolved
gompa and others added 2 commits March 3, 2022 16:11
@zvecr zvecr requested a review from a team March 3, 2022 15:31
@drashna drashna merged commit ae2c77c into qmk:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gompa @drashna @KarlK90 @zvecr