handwired/3dortho14u: refactor layout data #16475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove nonextant matrix positions from the layout data.
noroadsleft
added
enhancement
keyboard
keymap
via
fauxpark
approved these changes
Feb 28, 2022
|
these key positions exist when wired as individual keys rather than 6u space or 2u enter. |
|
How would you feel about a PR that added the full ortho layout back in? |
|
Yep |
xia0
added a commit
to xia0/qmk_firmware
that referenced
this pull request
Mar 1, 2022
This reverts commit 3ac769b.
I'll just PR a reversion of this. |
noroadsleft
pushed a commit
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes nonextant matrix positions from the layout data.
cc @xia0 (keyboard maintainer)
Types of Changes
Checklist