Add support for driving unselected row/col. #16278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slight fix and maintenance burden improvement -- Keychron Q2 uses a pin with a stronger pull resistor than the internal MCU pins, which renders that pin unusable.
Rather than maintaining an entirely separate custom matrix implementation, this allows for driving unselected pins as output-high instead of input-high.
Also removes the broken custom implementation of the Q2 matrix accordingly.
Types of Changes
Checklist