Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for driving unselected row/col. #16278

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 9, 2022

Description

Slight fix and maintenance burden improvement -- Keychron Q2 uses a pin with a stronger pull resistor than the internal MCU pins, which renders that pin unusable.

Rather than maintaining an entirely separate custom matrix implementation, this allows for driving unselected pins as output-high instead of input-high.

Also removes the broken custom implementation of the Q2 matrix accordingly.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Copy link
Member Author

tzarc commented Feb 9, 2022

Renders #16200 irrelevant. Fixes #16097.

@tzarc tzarc linked an issue Feb 9, 2022 that may be closed by this pull request
@tzarc tzarc mentioned this pull request Feb 9, 2022
14 tasks
@tzarc
Copy link
Member Author

tzarc commented Feb 9, 2022

CC @lokher @lalalademaxiya1

@tzarc tzarc merged commit efdaa7f into qmk:master Feb 9, 2022
@tzarc tzarc deleted the q2-matrix-fix branch February 9, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Keychron Q2 default config has some issues on Linux
2 participants