Add splitkb Kyria rev. 2 #16178
Merged
Add splitkb Kyria rev. 2 #16178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splitkb
approved these changes
Feb 3, 2022
drashna
requested changes
Feb 3, 2022
drashna
requested changes
Feb 7, 2022
drashna
approved these changes
Feb 11, 2022
fauxpark
reviewed
Feb 12, 2022
|
Is there anything we can do to get this pull request merged into the main branch? |
|
Let's wait for #16377 to be merged, and if it works, the same change can be applied here. |
fauxpark
requested changes
Feb 19, 2022
|
Requested changes have been applied, please let us know if there's anything else that should be patched up :) |
fauxpark
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the code to support the newest revision of splitkb's Kyria.
Description
Compared to the Kyria 1.x, the 2.x series features the following significant changes:
This means a new software revision is required as those make it backwards incompatible.
The code is pretty much a copy/paste from rev1, with minor changes where neccesary.
Types of Changes
Checklist
Note:
make keyboard:allreturned firmware size errors, but those were already present before this commit.Note: Proton-C support has not been tested as we do not have a pair of controllers at hand.