Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume as default encoder documentation example #15678

Merged
merged 2 commits into from
Jan 2, 2022
Merged

Volume as default encoder documentation example #15678

merged 2 commits into from
Jan 2, 2022

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Dec 31, 2021 •
edited
Loading

Description

Volume control is a more logical and frequently used function for encoders

Types of Changes

  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team December 31, 2021 07:08
fauxpark
fauxpark reviewed Dec 31, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be worth changing the pageup/down example to RGB hue +/-, to demonstrate the use of functions instead of tap_code()

@drashna
Copy link
Member

drashna commented Dec 31, 2021

Also may be worth using tap_code_delay for the volume keycodes, since they're likely to have issues.

@filterpaper
Copy link
Contributor Author

Thanks for the great ideas.

@drashna drashna merged commit 6f043c5 into qmk:master Jan 2, 2022
This was referenced Jan 2, 2022
Closed
Open
@filterpaper filterpaper deleted the encodersdoc-volume branch January 2, 2022 08:23
maherma-adg pushed a commit to maherma-adg/qmk_firmware that referenced this pull request Jan 4, 2022
@filterpaper @maherma-adg
Volume as default encoder documentation example (qmk#15678)
43a749c 
Co-authored-by: filterpaper <filterpaper@localhost>
ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022
@filterpaper @ryphon
Volume as default encoder documentation example (qmk#15678)
7162d7d 
Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @fauxpark