Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate serial_uart usages to UART driver #15479

Merged
merged 16 commits into from
Dec 15, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Migrate Dichotomy to UART driver
  • Loading branch information
fauxpark committed Dec 15, 2021
commit 0a174bcd686e5923f1534772b69ee1952d7f6352
9 changes: 0 additions & 9 deletions keyboards/dichotomy/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT
//#define NO_ACTION_MACRO
//#define NO_ACTION_FUNCTION

//UART settings for communication with the RF microcontroller
#define SERIAL_UART_BAUD 1000000
#define SERIAL_UART_RXD_PRESENT (UCSR1A & _BV(RXC1))
#define SERIAL_UART_INIT_CUSTOM \
/* enable TX and RX */ \
UCSR1B = _BV(TXEN1) | _BV(RXEN1); \
/* 8-bit data */ \
UCSR1C = _BV(UCSZ11) | _BV(UCSZ10);
8 changes: 5 additions & 3 deletions keyboards/dichotomy/dichotomy.c
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
#include "dichotomy.h"

//#include "uart.h"

void pointing_device_task(void){
/*report_mouse_t currentReport = {};
uint32_t timeout = 0;

//the m character requests the RF slave to send the mouse report
SERIAL_UART_DATA = 'm';
uart_write('m');

//trust the external inputs completely, erase old data
uint8_t uart_data[5] = {0};
Expand All @@ -15,15 +17,15 @@ void pointing_device_task(void){
//wait for the serial data, timeout if it's been too long
//this only happened in testing with a loose wire, but does no
//harm to leave it in here
while(!SERIAL_UART_RXD_PRESENT){
while(!uart_available()){
timeout++;
if (timeout > 10000){
xprintf("\r\nTIMED OUT");
break;
}
}
xprintf("\r\nGOT DATA for %d",i);
uart_data[i] = SERIAL_UART_DATA;
uart_data[i] = uart_read();
}

//check for the end packet, bytes 1-4 are movement and scroll
Expand Down
10 changes: 5 additions & 5 deletions keyboards/dichotomy/matrix.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "dichotomy.h"
#include "pointing_device.h"
#include "report.h"
#include "protocol/serial.h"
#include "uart.h"

#if (MATRIX_COLS <= 8)
# define print_matrix_header() print("\nr/c 01234567\n")
Expand Down Expand Up @@ -94,7 +94,7 @@ uint8_t matrix_cols(void) {

void matrix_init(void) {
matrix_init_quantum();
serial_init();
uart_init(1000000);
}

uint8_t matrix_scan(void)
Expand All @@ -104,7 +104,7 @@ uint8_t matrix_scan(void)
uint32_t timeout = 0;

//the s character requests the RF slave to send the matrix
SERIAL_UART_DATA = 's';
uart_write('s');

//trust the external keystates entirely, erase the last data
uint8_t uart_data[11] = {0};
Expand All @@ -114,14 +114,14 @@ uint8_t matrix_scan(void)
//wait for the serial data, timeout if it's been too long
//this only happened in testing with a loose wire, but does no
//harm to leave it in here
while(!SERIAL_UART_RXD_PRESENT){
while(!uart_available()){
timeout++;
if (timeout > 10000){
xprintf("\r\nTime out in keyboard.");
break;
}
}
uart_data[i] = SERIAL_UART_DATA;
uart_data[i] = uart_read();
}

//check for the end packet, the key state bytes use the LSBs, so 0xE0
Expand Down
3 changes: 2 additions & 1 deletion keyboards/dichotomy/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ NKRO_ENABLE = yes # Enable N-Key Rollover
# BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality

# # project specific files
SRC += matrix.c serial_uart.c
SRC += matrix.c
QUANTUM_LIB_SRC += uart.c