Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial QMK Support for the Han60 #15137

Closed
wants to merge 23 commits into from
Closed

Initial QMK Support for the Han60 #15137

wants to merge 23 commits into from

Conversation

farhandsome
Copy link

Description

Adding QMK support for the upcoming keyboard Han60.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/han60/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 12, 2021 22:57
keyboards/han60/config.h Outdated Show resolved Hide resolved
keyboards/han60/info.json Outdated Show resolved Hide resolved
keyboards/han60/readme.md Outdated Show resolved Hide resolved
keyboards/han60/readme.md Outdated Show resolved Hide resolved
keyboards/han60/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/han60/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/han60/info.json Outdated Show resolved Hide resolved
keyboards/han60/han60.h Outdated Show resolved Hide resolved
keyboards/han60/han60.c Outdated Show resolved Hide resolved
keyboards/han60/config.h Outdated Show resolved Hide resolved
@farhandsome farhandsome marked this pull request as draft November 15, 2021 21:48
farhandsome and others added 3 commits November 16, 2021 00:05
- Reworked keymap
- Reworked info.json
- Reworked han60.h
- Changed to unix line endings
@farhandsome farhandsome marked this pull request as ready for review November 16, 2021 20:25
keyboards/han60/readme.md Show resolved Hide resolved
@farhandsome farhandsome requested a review from fauxpark November 17, 2021 02:19
keyboards/han60/han60.h Outdated Show resolved Hide resolved
keyboards/han60/han60.h Outdated Show resolved Hide resolved
keyboards/han60/info.json Outdated Show resolved Hide resolved
keyboards/han60/info.json Outdated Show resolved Hide resolved
@farhandsome farhandsome requested a review from fauxpark November 17, 2021 15:10
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Nov 18, 2021
@farhandsome
Copy link
Author

@fauxpark @zvecr

Hey all, just wanted to get an update on this!

farhandsome and others added 2 commits November 23, 2021 20:40
Accidentally added back in.

Co-authored-by: Drashna Jaelre <[email protected]>
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore these files.

Comment on lines +89 to +96
keyboards/aos/tkl/keymaps/via/rules.mk
keyboards/aos/tkl/keymaps/via/keymap.c
keyboards/chavdai40/keymaps/42keys-dvorak/config.h
keyboards/chavdai40/keymaps/42keys-dvorak/keymap.c
keyboards/tempo_turtle/bradpad/keymaps/4brad/config.h
keyboards/tempo_turtle/bradpad/keymaps/4brad/keymap.c
keyboards/tempo_turtle/bradpad/keymaps/4brad/rules.mk
lib/chibios-contrib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
keyboards/aos/tkl/keymaps/via/rules.mk
keyboards/aos/tkl/keymaps/via/keymap.c
keyboards/chavdai40/keymaps/42keys-dvorak/config.h
keyboards/chavdai40/keymaps/42keys-dvorak/keymap.c
keyboards/tempo_turtle/bradpad/keymaps/4brad/config.h
keyboards/tempo_turtle/bradpad/keymaps/4brad/keymap.c
keyboards/tempo_turtle/bradpad/keymaps/4brad/rules.mk
lib/chibios-contrib

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry about that.

Accidentally deleted some files.

Co-authored-by: Ryan <[email protected]>
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files need to be restored too.

@farhandsome
Copy link
Author

@fauxpark

Do you know how I can restore the files? It won't let me revert the changes on Github Desktop.

@drashna
Copy link
Member

drashna commented Nov 28, 2021

You may need to rebase to fix the issues.

@farhandsome
Copy link
Author

Closing this request and will re-open without the gitignore issues.

@farhandsome farhandsome deleted the han60 branch November 28, 2021 06:32
@farhandsome
Copy link
Author

#15332

This is now the current request for the Han60 files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants