Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pixel Rain RGB Matrix effect #14155

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Add Pixel Rain RGB Matrix effect #14155

merged 6 commits into from
Nov 1, 2021

Conversation

filterpaper
Copy link
Contributor

Description

Pixel Rain effect that randomly light keys, with random hues.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@stale
Copy link

stale bot commented Oct 11, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@tzarc
Copy link
Member

tzarc commented Nov 1, 2021

If we can get the conflicts resolved, it can go in.

@stale stale bot removed the awaiting changes label Nov 1, 2021
@filterpaper
Copy link
Contributor Author

Thanks for the review @tzarc. Conflicts are resolved with rebase.

@tzarc tzarc merged commit 2173b53 into qmk:develop Nov 1, 2021
@filterpaper filterpaper deleted the pixel_rain branch November 2, 2021 05:11
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@filterpaper @ptrxyz
Add Pixel Rain RGB Matrix effect (qmk#14155)
58ec39f 
* Add Pixel animation header file

* Add Pixel animation to documentation

* Add Pixel animation to core include file

* Remove unintended spaces

* Remove seeding of PRNG

* Increase frequency of lit keys

Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @tzarc @drashna