Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align AW20216 driver #13712

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Align AW20216 driver #13712

merged 6 commits into from
Jul 27, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 26, 2021

Description

Slight tidy up of a few things,

  • Align api with existing ISSI drivers
    • mostly handing the DRIVER_x stuff within rgb_matrix_drivers.c
  • Reuse of some failure conditions
  • Align some terminology

Saving a whole 236 bytes.... wooo... I guess.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 26, 2021
@tzarc tzarc requested a review from a team July 26, 2021 00:16
@zvecr
Copy link
Member Author

zvecr commented Jul 26, 2021

@Gigahawk as the initial implementer, if you could give the changes a look over that would be awesome.

@zvecr zvecr requested a review from tzarc July 26, 2021 23:16
@zvecr zvecr merged commit 3858a78 into qmk:develop Jul 27, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Align AW20216 driver

* Update drivers/awinic/aw20216.h

Co-authored-by: Ryan <[email protected]>

* Review comments

* formatting fixes

* stop if start failed?

* review comments

Co-authored-by: Ryan <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Align AW20216 driver

* Update drivers/awinic/aw20216.h

Co-authored-by: Ryan <[email protected]>

* Review comments

* formatting fixes

* stop if start failed?

* review comments

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants