Fix rgbkb/sol/rev2/config.h after changes introduced in #13349 #13531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Sol2 rev2 config.h. It was not building after changes from qmk#13349 where defines were streamlined to eliminate a compile warning. * reintroduced FULLHAND_LEDS define (required in rev2.c to calculate LED position offset) * change default RGBLED_NUM when neither FULLHAND nor SF is enabled (was 0 instead 124)
XScorpion2
suggested changes
Jul 13, 2021
| @@ -30,19 +30,22 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
|
|
|||
| // Underglow / DIY Tent Glow are parallel to the top row leds, no separate define | |||
| #ifdef FULLHAND_ENABLE | |||
| #define FULLHAND_LEDS 24 | |||
| #ifdef LED_MIRRORED | ||
| #define RGBLED_NUM 74 | ||
| #else | ||
| #define RGBLED_NUM 148 | ||
| #endif | ||
| #elif SF_ENABLE | ||
| #define FULLHAND_LEDS 38 |
| #ifdef LED_MIRRORED | ||
| #define RGBLED_NUM 81 | ||
| #else | ||
| #define RGBLED_NUM 162 | ||
| #endif | ||
| #else | ||
| #define RGBLED_NUM 0 | ||
| #define FULLHAND_LEDS 0 | ||
| #define RGBLED_NUM 124 |
There was a problem hiding this comment.
change these lines to:
#ifdef LED_MIRRORED
#define RGBLED_NUM 62
#else
#define RGBLED_NUM 124
#endif
|
Closing this PR as #13533 fixed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed rgbkb/sol/rev2/config.h config.h. It was not building after changes from #13349 where defines were streamlined to eliminate a compile warning.
Personally think that the previous version that was using expressions in the defines was a bit nicer. Less mental math to make mistakes in. Unfortunately I don't think there is a way to do that without having the linter complain about an 'invalid literal for int() with base 10'.
Types of Changes
Issues Fixed or Closed by This PR
Checklist