Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite of WPM.c (no float) #13359

Closed
wants to merge 3 commits into from
Closed

rewrite of WPM.c (no float) #13359

wants to merge 3 commits into from

Conversation

jurgen-kluft
Copy link

Description

The wpm.c implementation was rewritten to basically remove the use of float due to the resulting large code size increase.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 27, 2021
@zvecr zvecr changed the base branch from master to develop June 27, 2021 21:37
quantum/wpm.c Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Aug 21, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Aug 21, 2021
@stale
Copy link

stale bot commented Oct 11, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@jurgen-kluft
Copy link
Author

Still awaiting approval or feedback...

@stale stale bot removed the awaiting changes label Oct 15, 2021
@drashna
Copy link
Member

drashna commented Oct 15, 2021

Looks good, and improves the behavior of the code.

However, this does compete with #13902. Both do look good, though.

@drashna drashna requested a review from a team October 15, 2021 03:55
@drashna
Copy link
Member

drashna commented Dec 7, 2021

I'm going to go ahead and close this PR, since the wpm feature no longer uses floats.

@drashna drashna closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants