-
-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LAZYDESIGNERS/THE60/rev2 #13015
Conversation
@drashna I checked others' work and fixed the issue. Now it's using rev1/rev2 for different version. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently breaking the user workflow as lazydesigners/the60
will no longer be a valid build target.
You can work this around by having the following files:
keyboards/lazydesigners/the60/rules.mk
file with the following content:
DEFAULT_FOLDER = lazydesigners/the60/rev1
keyboards/lazydesigners/the60/the60.h
:
#pragma once
#include "quantum.h"
#ifdef KEYBOARD_lazydesigners_the60_rev1
#include "rev1.h"
#elif KEYBOARD_lazydesigners_the60_rev2
#include "rev2.h"
endif
keyboards/lazydesigners/the60/the60.c
:
#include "the60.h"
Co-authored-by: Erovia <[email protected]>
Add the60.h, the60.c and rules.mk under THE60 folder.
@Erovia Got it! I have added the file to make 'make lazydesigners/the60:default' work. As rev2 will be the main version that THE60 will be made, I pointed the default folder to rev2. Thanks for helping me with this! |
Co-authored-by: Drashna Jaelre <[email protected]>
@Erovia Deleted rules.mk, the60.c and the60.h. Tested and everything is OK. |
Co-authored-by: Erovia <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Erovia <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Erovia <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>
Add support for LAZYDESIGNERS/THE60/rev2
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist