dynamic macros: Trim the trailing modifiers; further cleanup #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cording More specifically, we save them and then place the `macro_end` pointer before them so they are essentially ignored and the other macro may freely overwrite them.
|
Additionally https://github.com/qmk/qmk_firmware/wiki/Macros needs to be updated after @cinaeco's changes. How can I update it? It seems to be read-only for me and I don't think Github supports wiki pull requests. |
|
These changes work well too, I can see the fixed macro buffer size in debug. Thanks! Yeah, the wiki still needs to be updated. |
|
Perfect! Thanks :) yeah, we have the wiki as read-only for now - if you want, you can paste the changed sections/a diff here! We're still working out how to manage these permissions :/ |
vifon
added a commit
to vifon/qmk_firmware_docs
that referenced
this pull request
May 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit late with the last batch of commits for the last PR (#1273), so here they are.