Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved tokyo60/ into tokyokeyboard/tokyo60/. #12023

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Moved tokyo60/ into tokyokeyboard/tokyo60/. #12023

merged 3 commits into from
Jun 16, 2021

Conversation

quadcube
Copy link

@quadcube quadcube commented Feb 26, 2021 •
edited
Loading

Description

Moved tokyo60 keyboard into tokyokeyboard vendor directory.

Types of Changes

  1. Moved tokyo60/ into tokyokeyboard/tokyo60/.
  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 26, 2021
@quadcube quadcube mentioned this pull request Feb 26, 2021
Merged
6 tasks
@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:28
@tzarc
Copy link
Member

tzarc commented Feb 27, 2021

Sorry about that, GitHub decided to delete the develop branch from upstream when we merged it, despite being told otherwise. Reopened.

@tzarc tzarc reopened this Feb 27, 2021
@quadcube quadcube mentioned this pull request Mar 17, 2021
Merged
6 tasks
@stale
Copy link

stale bot commented Apr 18, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@quadcube
Copy link
Author

@tzarc Hi, could you help to review the pull request? Thanks!

@drashna drashna requested a review from a team April 19, 2021 04:59
fauxpark
fauxpark requested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme will need to be updated with the new name of the keyboard.

@quadcube
Copy link
Author

The readme will need to be updated with the new name of the keyboard.

Hi, about the name, is it regarding the make instruction part?
Fixed the instruction with the correct path and broken readme image link

@stale
Copy link

stale bot commented Jun 16, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna merged commit f5c2f71 into qmk:develop Jun 16, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@quadcube @nhongooi
[Keyboard] Moved tokyo60/ into tokyokeyboard/tokyo60/. (qmk#12023)
f5022c4 
* Moved tokyo60/ into tokyokeyboard/tokyo60/.

* Updated make instruction, fixed broken image link

* Fixed still broken image link.
@peepeetee peepeetee mentioned this pull request Jan 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
awaiting changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quadcube @tzarc @drashna @fauxpark