-
-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for m65 a simple 5x13 ortholinear #12012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also required, GPL compatible licence headers on all .h
and .c
files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the ChibiOS config needed here at all? Apparently this keyboard does not even use PWM for backlight or anything else, and USART is also not actually used; if these options come from another keyboard used as a template, they can be removed.
Sorry about that, GitHub decided to delete the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @sigprof here https://github.com/qmk/qmk_firmware/pull/12012/files#r583111072
Individual keymaps shouldn't have to know which pins are connected to what—these should be abstracted away on the keyboard level.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist