Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for m65 a simple 5x13 ortholinear #12012

Closed
wants to merge 0 commits into from
Closed

add support for m65 a simple 5x13 ortholinear #12012

wants to merge 0 commits into from

Conversation

alinelena
Copy link
Contributor

@alinelena alinelena commented Feb 25, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also required, GPL compatible licence headers on all .h and .c files

@zvecr zvecr requested a review from a team February 25, 2021 17:21
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the ChibiOS config needed here at all? Apparently this keyboard does not even use PWM for backlight or anything else, and USART is also not actually used; if these options come from another keyboard used as a template, they can be removed.

@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:28
@tzarc
Copy link
Member

tzarc commented Feb 27, 2021

Sorry about that, GitHub decided to delete the develop branch from upstream when we merged it, despite being told otherwise. Reopened.

@tzarc tzarc reopened this Feb 27, 2021
@alinelena alinelena changed the title WIP: add support for m65 a simple 5x13 ortholinear add support for m65 a simple 5x13 ortholinear Feb 27, 2021
@alinelena alinelena requested review from fauxpark and zvecr February 27, 2021 21:19
@alinelena alinelena requested a review from drashna February 28, 2021 23:38
Copy link

@liyang liyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @sigprof here https://github.com/qmk/qmk_firmware/pull/12012/files#r583111072

Individual keymaps shouldn't have to know which pins are connected to what—these should be abstracted away on the keyboard level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants