-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Printing Tool Displays Unintuitive Key Labels Instead of Readable Key Names #1363
Comments
Sorry. Could you give more context. Which one is your preference? Unintuitive is somewhat subjective so it's difficult to understand. Maybe some annotation around which representation you think is problematic and some possible solutions. |
Interesting that it's doing that. Maybe it should be a toggle. |
Took some time to look at this today and the issue is how they keys are represented in the printing view. In the visual keymap there are specialized components for each of these container types. In the PrintKey.vue component we just have the single component and it tries it's best to do the right thing for each keycode. One quick fix, would be to stop printing the QMK code and just show the display version. If that's acceptable I'll open a PR. |
Issue [1363](#1363) Change the PrintKey to show the `.name` instead of the `.code` attribute because it's less human friendly. Remove some of the extraneous formatting around the element. This stems slightly from the different way we render Key components in the printing vs editing.
Issue [1363](#1363) Change the PrintKey to show the `.name` instead of the `.code` attribute because it's less human friendly. Remove some of the extraneous formatting around the element. This stems slightly from the different way we render Key components in the printing vs editing.
ok, this should be resolved. I'll close it for now. Thanks. |
Describe the Bug
Default tool key labels:

Example from Chrome's Print Feature:

QMK Configurator print feature:

Additional Context?
No response
The text was updated successfully, but these errors were encountered: