Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOLOE-10 initial commit basic banner component #94

Merged
merged 2 commits into from
May 8, 2024

Conversation

stvp-qld
Copy link
Member

@stvp-qld stvp-qld commented May 8, 2024

@duttonw
Copy link
Member

duttonw commented May 8, 2024

> [email protected] lint
> eslint --fix --ext .js,.json --ignore-pattern 'docs/*' --ignore-pattern 'dist/*' .


/home/runner/work/qgds-qol-mvp/qgds-qol-mvp/src/components/bs5/banner/banner.stories.js
Error:   27:[11](https://github.com/qld-gov-au/qgds-qol-mvp/actions/runs/8994943024/job/24709147672?pr=94#step:10:12)  error  Duplicate key 'dark-alt'  no-dupe-keys

/home/runner/work/qgds-qol-mvp/qgds-qol-mvp/src/stories/templates/ContentPage/ContentPage.stories.js
Warning:   18:3  warning  Named exports should not use the name annotation if it is redundant to the name that would be generated by the export name  storybook/no-redundant-story-name
Warning:   35:3  warning  Named exports should not use the name annotation if it is redundant to the name that would be generated by the export name  storybook/no-redundant-story-name

/home/runner/work/qgds-qol-mvp/qgds-qol-mvp/src/stories/templates/LandingPage/LandingPage.stories.js
Warning:   [17](https://github.com/qld-gov-au/qgds-qol-mvp/actions/runs/8994943024/job/24709147672?pr=94#step:10:18):3  warning  Named exports should not use the name annotation if it is redundant to the name that would be generated by the export name  storybook/no-redundant-story-name
Warning:   24:3  warning  Named exports should not use the name annotation if it is redundant to the name that would be generated by the export name  storybook/no-redundant-story-name

✖ 5 problems (1 error, 4 warnings)

Error: Process completed with exit code 1.

@stvp-qld stvp-qld merged commit c0ff7ca into develop May 8, 2024
3 of 5 checks passed
@elvishu elvishu deleted the QOLOE-10-banner-component branch June 13, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants