Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/Draft: Navigation/Header pattern v2.0 (includes search + improved colours) #86

Merged
merged 12 commits into from
May 8, 2024

Conversation

MitchAnderson93
Copy link
Member

@MitchAnderson93 MitchAnderson93 commented May 3, 2024

Task:

Figma reference / header variations

Includes:

  • Desktop search
  • Rewritten SCSS with Improved colours (needing QA/colours adjusted for each colour theme)
  • Includes 2x handlebars helpers I am using to determine rows in mega menu (unused)
  • Refractored/cleaned up QH header classes, now uses light/light-alt/dark/dark-alt as per conventions
  • Icons in menu/header at each breakpoint size (using QH svg sprite with ID's)
  • Rotate chevrons in list items (menu) and CTA/attribution bar

Still to do (functionality):

  • Colour QA (for each mode)
  • Mobile search (expand)
  • CTA (right) icons
  • Border (none) on final row items in mega menu (desktop) - hence why I made two helper's
  • Align mobile nav internal elements to expected state (right aligned expand button) with part clickable area
  • Breakout the pre header into seperate component so user can select colour combo's in JSON (preheader/header/nav combined story)

Still to do (non func):

  • Clean up/review JS/SCSS conventions
  • Resolve any list issues

@MitchAnderson93 MitchAnderson93 changed the title WIP/Draft: Header search + improved colours WIP/Draft: Navigation/Header pattern v2.0 (includes search + improved colours) May 6, 2024
@MitchAnderson93 MitchAnderson93 requested a review from duttonw May 6, 2024 08:35
@stvp-qld stvp-qld marked this pull request as ready for review May 8, 2024 04:23
@stvp-qld
Copy link
Member

stvp-qld commented May 8, 2024

Initial merge to develop for allow continued dev work in CMS.

Follow up PR's to follow for this component.

@stvp-qld stvp-qld merged commit cc8ae94 into develop May 8, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants