Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade storybook, move vite config from storybook main to its own file #37

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

duttonw
Copy link
Member

@duttonw duttonw commented Apr 10, 2024

  • Storybook 8.0.6
  • unwrap preview.js story wrapper and move them to each story can do its own thing on div's where required (useful for full page render stories)
  • cleanup unneeded dev dependancies
  • add themes (with None theme being default)
  • add viewports based on where css should change to next zone
  • prep chromatic to do difference viewport sizes
    (after we merge colour stories to reduce captures as it will double/triple the screen shots)

…le, cleanup story wrapper in preview so each story can do its own thing on div's
@duttonw duttonw merged commit 6b91bee into develop Apr 12, 2024
3 of 5 checks passed
stvp-qld pushed a commit that referenced this pull request Apr 16, 2024
…le (#37)

* Upgrade storybook, move vite config from storybook main to its own file, cleanup story wrapper in preview so each story can do its own thing on div's

* See if viewport 1200px caused the page to shift and cause delta in chromatic
@elvishu elvishu deleted the storybookPatchAndMoveStoryWrapperToComponents branch June 13, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants