Qoldev 77 hyperlinks on dfv #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghazal-salehi
force-pushed
the
QOLDEV-77-hyperlinks-on-DFV
branch
from
baf0cf4 to
6986811
Compare
ghazal-salehi
requested review from
ThrawnCA,
duttonw,
chris-randall-qol,
RossWebsterWork and
stvp-qld
ThrawnCA
reviewed
Jun 19, 2023
| } | ||
| #qg-primary-content .dfv-page-introduction a, #qg-primary-content .dfv-content a:not(.qg-links-list__link) { | ||
| color: $qg-blue-dark !important; | ||
| } | ||
|
|
||
| #qg-content #qg-primary-content .dfv-topics__link { | ||
| margin: 0 !important; |
There was a problem hiding this comment.
Why does this need to be !important?
There was a problem hiding this comment.
This is to override the default 2px margin. I can replace it with @include qg-global-link-styles($margin: 0);
I'll update it soon.
|
Can the build failures be looked into before approving and merging this? They might not be caused by this change, but I'd like to fix them before proceeding with confidence. |
It's the footer feedback test that Steve fixed yesterday. It was merged this morning. I'll rebase my changes to make sure. |
|
Buiid was successful. |
ThrawnCA
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying button styles to Dfv portal
This includes default, active, hover states. Also the vertical spacing in the link list is fixed as well.
https://oss-uat.clients.squiz.net/community/getting-support-health-social-issue/support-victims-abuse/domestic-family-violence/i-want-to-help-someone
Before:
After:
Before:
After:
