Qoldev 339 outline hovering underline

[ghazal-salehi]

https://ssq-qol.atlassian.net/browse/QOLDEV-339
Before:

After:

[ghazal-salehi]

I had to update this PR as the pb: 3px was impacting other links like nav items. The issue was caused because the standard links did not have any height applied to them. By assigning display value they would. This change also fixes https://ssq-qol.atlassian.net/browse/QOLDEV-322 (The logo outline issue in Safari)

[RossWebsterWork]

It seems like a nice fix, but I think making all links display as an inline-block may have unintended layout effects, such as for links which go over multiple lines.
I believe @ThrawnCA encountered this before in #749

[ThrawnCA]

This should not be applied globally. It has side effects on line spacing and wrapping.

[ghazal-salehi]

I think increasing line heights is inevitable to fix this issue, because the style lacks some vertical spacing to fit in both outline and underline. I excluded digital dashboard from the change.

[ghazal-salehi]

The impact on multi-line links looks like this:
Example on small size screen: https://oss-uat.clients.squiz.net/disability/legal-and-rights/advocacy

Before:

After:

I agree it is different, but does not look broken. I can ask Bec's opinion as well.

Such change would fix the outline for the logo in FireFox and Safari as well:

Before:

After:

I also noticed other in the system that did not have this issue (outline covering underline), already have display: inline-block, like nav items and qg-index-item.

https://www.qld.gov.au/disability/legal-and-rights/advocacy
https://www.qld.gov.au/disability

I checked Carl's PR, .pagination and .graph were excluded. I tested pagination has it's own class (page-link) to apply display: block to .
pagination: https://oss-uat.clients.squiz.net/search?query=test&num_ranks=10&tiers=off&collection=qld-gov&profile=qld&scope=&page=1&start_rank=1

I excluded #ict-tabcontainer a from the added style.
https://oss-uat.clients.squiz.net/digitalprojectsdashboard/dashboard?SQ_VARIATION_102100=0

[ghazal-salehi]

In links it is noticeable that it is rendered something in the middle, so not exactly covered, and not spaced enough. https://www.qld.gov.au/search?query=test&num_ranks=10&tiers=off&collection=qld-gov&profile=qld

Before:

After:

[ThrawnCA]

Restricting inline-block with a blacklist isn't enough. It shouldn't be the default.

[ghazal-salehi]

Closing the PR. This change needs to be done after reviewing font sizes by Bec. We can do this by using styles like outline-offset.