Puppeteer headless parameter #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v4.2.2
Merging 4.2.3 to master
This reverts commit e56d0dc.
QOLDEV-515 Return type of sfinder is a list
* QOLDEV-518 added console notice when a string replacement occurs * QOLDEV-518 double to single quotes * Release v4.2.3 (#1045) (#1057) Merging 4.2.3 to master --------- Co-authored-by: Steve Pegg <[email protected]>
ghazal-salehi
requested review from
duttonw,
ThrawnCA,
kundupz,
chris-randall-qol,
RossWebsterWork and
stvp-qld
Closed
* QOLDEV-518 added console notice when a string replacement occurs * QOLDEV-518 double to single quotes * Release v4.2.3 (#1045) (#1057) Merging 4.2.3 to master --------- Co-authored-by: Steve Pegg <[email protected]>
* QOLDEV-518 added console notice when a string replacement occurs * QOLDEV-518 double to single quotes * Release v4.2.3 (#1045) (#1057) Merging 4.2.3 to master --------- Co-authored-by: Steve Pegg <[email protected]>
ThrawnCA
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New puppeteer version caused our tests to fail. It was due to changes in headless parameter value being changed:
https://developer.chrome.com/articles/new-headless/