[QOLDEV-1005] update for CKAN 2.11 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
commented
Nov 12, 2024
ThrawnCA
commented
- update test container to support CKAN 2.11
- update to Selenium 4
- drop Python 2 support
- add Docker Compose 2 support
- replace Nosetests with pytest
- sync test config with other repos
- update test container to support CKAN 2.11 - update to Selenium 4 - drop Python 2 support - add Docker Compose 2 support - replace Nosetests with pytest - sync test config with other repos
.ahoy.yml
Outdated
| ahoy cli 'chmod -v u+x /usr/bin/ckan_cli; cp -v .docker/test.ini $CKAN_INI' | ||
| docker cp . $(sh bin/docker-compose.sh ps -q ckan):/srv/app/ | ||
| docker cp bin/ckan_cli $(sh bin/docker-compose.sh ps -q ckan):/usr/bin/ | ||
| ahoy cli 'chmod -v u+x /usr/bin/ckan_cli $APP_DIR/bin/*; cp -v .docker/test.ini $CKAN_INI' |
There was a problem hiding this comment.
Should this variable be in quotes or is app dir guaranteed to not have spaces?
There was a problem hiding this comment.
It's supplied by the parent container. Their suggested usage doesn't mention quoting it, and every other repo hasn't had issues. I guess it wouldn't hurt though.
ThrawnCA
force-pushed
the
QOLDEV-1005-ckan-2.11
branch
from
ed20570 to
cd46299
Compare
duttonw
approved these changes
Nov 13, 2024
ThrawnCA
force-pushed
the
QOLDEV-1005-ckan-2.11
branch
from
cd46299 to
86f0d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.