Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QOLSVC-9300] handle anonymous user objects gracefully #157

Merged
merged 1 commit into from
Feb 28, 2025
Merged

[QOLSVC-9300] handle anonymous user objects gracefully #157

merged 1 commit into from
Feb 28, 2025

Conversation

ThrawnCA
Copy link
Contributor

Not sure how this wasn't caught in testing earlier.

@ThrawnCA ThrawnCA requested a review from a team February 28, 2025 05:49
duttonw
duttonw approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@duttonw duttonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also have

else
Return false

Or return answer of sysadmin check

@ThrawnCA
Copy link
Contributor Author

Could also have

else Return false

Or return answer of sysadmin check

I don't quite follow. If the user is neither anonymous nor sysadmin, then it goes through further checks to see if they're an org admin/editor.

@ThrawnCA ThrawnCA merged commit a63c78e into develop Feb 28, 2025
6 checks passed
@duttonw
Copy link
Member

duttonw commented Feb 28, 2025

Nm, missed the bits after it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duttonw duttonw duttonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThrawnCA @duttonw