QOLDEV-455 fix recaptcha failure message on CKAN 2.10 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Aug 8, 2023
ThrawnCA
commented
- Inject reCAPTCHA failure message into CKAN 2.10 routing
- Add scenario test
…into QOLDEV-455-add-recaptcha
- Don't double up on scenario tests - Drop obsolete test data creation - Enable running specific scenario tests locally
- Login routes are different from CKAN 2.9
ThrawnCA
force-pushed
the
QOLDEV-455-add-recaptcha
branch
from
8419cc9 to
a2462ca
Compare
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
duttonw
reviewed
Aug 8, 2023
| def _gettext_wrapper(key): | ||
| translation = original_gettext(key) | ||
| if key == 'Login failed. Bad username or password.': | ||
| translation = translation.replace('or password.', 'or password or reCAPTCHA.') |
There was a problem hiding this comment.
Unsure if we still need this 'logged' in override.
1185b4c#diff-efa22cf47b1e8aa51b8cb0c79a87d1597c06fa9f71611bd8b95b07a8e3668910R24
There was a problem hiding this comment.
Huh. I thought I'd tested it locally on CKAN 2.9 and it didn't work without keeping that intercept, but I must have been doing something wrong that time, because yes, it works. Okay, taking that out.
duttonw
approved these changes
Aug 8, 2023
- Intercepting the message rendering covers all versions
…into QOLDEV-455-add-recaptcha
duttonw
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.