Develop to master - fix email notifications #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Dec 5, 2023
ThrawnCA
commented
- Update email notification template for CKAN 2.10
- Update tests for logout link conversion to POST.
QOLDEV-640 update scenario tests to handle POST-style logout
- Sync template with core to replace obsolete ungettext function and handle 'g' being absent
…'t available anymore in email context
[QOLSVC-4096] fix email notifications on CKAN 2.10
- Use 'reversed' to return the reverse list, not 'reverse' to change it in place
[QOLSVC-4096] fix list reversal
- This is cleaner and more future-compatible
[QOLSVC-4096] use Jinja filter for list reversal
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
RossWebsterWork
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.