Squashed commit including basis update and proxy support. #11
Conversation
|
|
There was a problem hiding this comment.
This looks good for the most part. Just a couple inline comments, but it's mostly about not removing 3.5 support yet (qiskit still supports it) and the syntax for proxy configs. I also think this needs documentation in the README about how the new proxy option is used
|
Ready for merge. Please advise if more changes are necessary. |
|
@mtreinish Any update on acceptance/merger? There is now another PR waiting after this one... |
There was a problem hiding this comment.
I apologize on the slow response time here, I have been busy with some other work the past couple of weeks. This looks better just some small comments inline.
The one big thing I want to understand better before merging this though is the basis gates change. There isn't a lot detail in the PR summary about why this was needed, is it actually the basis set of the backend or just a limit with the current terra release's transpiler?
Summary
Details and comments
The set of basis gates was insufficient to allow submission to our system. By adding additional allowed basis gates we were able to get past the compilation and submit the QASM to our API.
Proxies are now supported with the limitation that they will revert from websockets to polling of the restful interface. For long-running/long-queued jobs this may impact the response time somewhat, but it should be limited to a small fraction of the overall wait-time.