Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the includenodoc and customcarditem directives #628

Merged
merged 1 commit into from
May 12, 2023

Conversation

Eric-Arellano
Copy link
Contributor

According to grep, these weren't actually used.

CustomCalloutItemDirective is used though. It's used in a few other projects too, so I'm likely going to move this to qiskit_sphinx_theme in its 1.13 release so that you don't have to copy and paste the code. Tracked by Qiskit/qiskit_sphinx_theme#323.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4960958757

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.971%

Totals Coverage Status
Change from base Build 4959809861: 0.0%
Covered Lines: 2672
Relevant Lines: 2874

💛 - Coveralls

@woodsp-ibm woodsp-ibm added stable backport potential The bug might be minimal and/or import enough to be port to stable type: documentation 📖 Issues related to documentation automerge labels May 12, 2023
@mergify mergify bot merged commit bbc7341 into qiskit-community:main May 12, 2023
mergify bot pushed a commit that referenced this pull request May 12, 2023
(cherry picked from commit bbc7341)

# Conflicts:
#	docs/conf.py
#	docs/custom_directives.py
@Eric-Arellano Eric-Arellano deleted the rm-more-directives branch May 12, 2023 20:09
@woodsp-ibm
Copy link
Member

@Mergifyio backport stable/0.6

@mergify
Copy link
Contributor

mergify bot commented May 12, 2023

backport stable/0.6

✅ Backports have been created

adekusar-drl pushed a commit that referenced this pull request May 15, 2023
) (#629)

* Remove the `includenodoc` and `customcarditem` directives (#628)

(cherry picked from commit bbc7341)

# Conflicts:
#	docs/conf.py
#	docs/custom_directives.py

* Update custom_directives.py

Fix conflict

* Update conf.py

Fix conflicts

* Update conf.py

Remove extra blank line

---------

Co-authored-by: Eric Arellano <[email protected]>
Co-authored-by: Steve Wood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge stable backport potential The bug might be minimal and/or import enough to be port to stable type: documentation 📖 Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants