Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for python 3.7 #625

Merged
merged 11 commits into from
May 11, 2023
Merged

Drop support for python 3.7 #625

merged 11 commits into from
May 11, 2023

Conversation

adekusar-drl
Copy link
Collaborator

Summary

This PR updates the module and CI checks to python 3.8 as the oldest support version of python.

@adekusar-drl adekusar-drl added this to the 0.7.0 milestone May 10, 2023
@coveralls
Copy link

coveralls commented May 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4952143366

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.02%) to 92.971%
Totals Coverage Status
Change from base Build 4938256798: 1.02%
Covered Lines: 2672
Relevant Lines: 2874
💛 - Coveralls

@woodsp-ibm
Copy link
Member

This is not related to the failure, but I noticed the warning from pylint. In the pylint.rc file - the last line

overgeneral-exceptions=Exception

should now be

overgeneral-exceptions=builtins.Exception

to avoid this warning

pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.Exception' ?) instead.

@adekusar-drl adekusar-drl merged commit bf3d88c into qiskit-community:main May 11, 2023
@adekusar-drl adekusar-drl deleted the drop_3_7 branch May 11, 2023 22:18
@woodsp-ibm woodsp-ibm mentioned this pull request May 16, 2023
Merged
oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
@adekusar-drl @woodsp-ibm
Drop support for python 3.7 (#625)
5348282 
* drop 3.7

* reduce to ubuntu

* remove ubuntu

* add parameter

* Update .github/workflows/main.yml

Co-authored-by: Steve Wood <[email protected]>

* remove 3.7

* fix lint

* push empty

---------

Co-authored-by: Steve Wood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adekusar-drl @coveralls @woodsp-ibm