Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use seeded rng to generate regressor test data #616

Merged
merged 3 commits into from
May 3, 2023

Conversation

woodsp-ibm
Copy link
Member

Summary

Regressor tests sometimes fail with a message like this

AssertionError: -3.743118339666668 not greater than 0.5

I have switched the tests such that instead of using truly random data each time it uses a fixed random set determined by seeding that hopefully will avoid this random failure showing up.

Details and comments

@woodsp-ibm woodsp-ibm added the type: ci 🔧 Related to Continuous Integration workflows label May 2, 2023
@coveralls
Copy link

coveralls commented May 2, 2023

Pull Request Test Coverage Report for Build 4869242811

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.944%

Totals Coverage Status
Change from base Build 4865610668: 0.0%
Covered Lines: 2545
Relevant Lines: 2768

💛 - Coveralls

@adekusar-drl adekusar-drl merged commit 09e6c12 into qiskit-community:main May 3, 2023
@woodsp-ibm woodsp-ibm deleted the rng branch May 3, 2023 13:58
oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
* Use seeded rng to generate regressor test data

* Copyright date

---------

Co-authored-by: Anton Dekusar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: ci 🔧 Related to Continuous Integration workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants