-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wheels deploying workflow #43
Conversation
Since we're in an emergency situation, I dropped the generation of wheels for macos and windows, since (at least macos) has been proven to be incompatible with It would be nice to have at least Quimb support for all platforms, but I'd face the problem after the release. (I had a look to Qibojit, but there is no valuable solution in there: simply, the Cuquantum and CuPy dependencies are undeclared - they are only in a suitable Poetry group in Qibo, but it's definitely the wrong place) |
In order to install the dependencies, the That would make all workflows failing in the GitHub CI, so I used a pre-built wheel, that can be installed in any supported platform (i.e. Linux), and the CUDA libraries are just dynamically discovered (so, if you don't run CUDA code, their absence won't be discovered as well). To do this, I had to pick a given CUDA version (at least major), and I went for |
Could we use the CUDA availability from a preceding |
021bf78
to
6655db0
Compare
We could, but with no benefit in the short term: the purpose of that |
That's true as we only have one build job for both |
Yes, but I'd try to design anything more complex after the release, to minimize the risk of having no release at all by Tuesday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like silenceing extras is useful, thanks.
Yup, that makes sense. Proceed to approve and merge this PR. |
If we're aiming for a release, we should also make sure to release something.